Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SonyMisc2b makernote tags (tag 9404) #1792

Merged
merged 3 commits into from
Jul 23, 2021

Conversation

postscript-dev
Copy link
Collaborator

@postscript-dev postscript-dev commented Jul 21, 2021

Changes:

  • Add function to generalize getExifModel()
  • Add tags, pretty printing and tag group selector function
  • Update docs
  • Add tests

Source: https://exiftool.org/TagNames/Sony.html

Function generalizes `getExifModel()`, allowing any value in a tag to
be accessed.
Changes:
+ Add tags, pretty printing and tag group selector function
+ Update docs

Source: https://exiftool.org/TagNames/Sony.html
@codecov
Copy link

codecov bot commented Jul 21, 2021

Codecov Report

Merging #1792 (2031224) into main (82057a6) will increase coverage by 0.03%.
The diff coverage is 83.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1792      +/-   ##
==========================================
+ Coverage   67.48%   67.52%   +0.03%     
==========================================
  Files         151      151              
  Lines       20861    20901      +40     
==========================================
+ Hits        14079    14113      +34     
- Misses       6782     6788       +6     
Impacted Files Coverage Δ
src/makernote_int.hpp 91.66% <ø> (ø)
src/tags_int.cpp 87.20% <ø> (ø)
src/tags_int.hpp 90.90% <ø> (ø)
src/tiffimage_int.cpp 89.28% <ø> (ø)
src/sonymn_int.cpp 73.21% <76.00%> (+0.80%) ⬆️
src/makernote_int.cpp 80.04% <94.11%> (+0.50%) ⬆️
src/tiffcomposite_int.cpp 83.23% <0.00%> (+0.11%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 82057a6...2031224. Read the comment docs.

@postscript-dev postscript-dev changed the title WIP: Add SonyMisc2b makernote tags (tag 9404) Add SonyMisc2b makernote tags (tag 9404) Jul 21, 2021
@kevinbackhouse kevinbackhouse merged commit c474277 into Exiv2:main Jul 23, 2021
@postscript-dev postscript-dev deleted the add_SonyMisc2b_tags branch July 26, 2021 10:59
@postscript-dev postscript-dev restored the add_SonyMisc2b_tags branch July 26, 2021 11:00
@postscript-dev postscript-dev deleted the add_SonyMisc2b_tags branch October 20, 2021 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants